Browse Source

Re-enable 5.6 tests (#1390)

Motivation:

https://bugs.swift.org/browse/SR-15955 precluded tests from running on
Swift 5.6. This has been resolved in Swift 5.6.1.

Modifications:

- Re-enable tests on 5.6
- Disable TSAN on 5.6 (the tests for AsyncServerHandler are abusing
  `EmbeddedChannel`; the tests will be rewritten when the handler state
  machine is rewritten and the AsyncEmbeddedChannel comes to fruition)

Result:

Tests run on 5.6
George Barnett 3 years ago
parent
commit
c4efc34e70
1 changed files with 1 additions and 5 deletions
  1. 1 5
      .github/workflows/ci.yaml

+ 1 - 5
.github/workflows/ci.yaml

@@ -25,7 +25,7 @@ jobs:
       matrix:
       matrix:
         include:
         include:
           - image: swift:5.6-focal
           - image: swift:5.6-focal
-            swift-test-flags: "--enable-test-discovery --sanitize=thread"
+            swift-test-flags: "--enable-test-discovery"
           - image: swift:5.5-focal
           - image: swift:5.5-focal
             swift-test-flags: "--enable-test-discovery"
             swift-test-flags: "--enable-test-discovery"
           - image: swift:5.4-focal
           - image: swift:5.4-focal
@@ -46,8 +46,6 @@ jobs:
       run: swift build ${{ matrix.swift-build-flags }}
       run: swift build ${{ matrix.swift-build-flags }}
       timeout-minutes: 20
       timeout-minutes: 20
     - name: 🧪 Test
     - name: 🧪 Test
-      # Skip tests on 5.6: https://bugs.swift.org/browse/SR-15955
-      if: ${{ matrix.image != 'swift:5.6-focal' }}
       run: swift test ${{ matrix.swift-test-flags }}
       run: swift test ${{ matrix.swift-test-flags }}
       timeout-minutes: 20
       timeout-minutes: 20
   performance-tests:
   performance-tests:
@@ -127,8 +125,6 @@ jobs:
         GRPC_NO_NIO_SSL: 1
         GRPC_NO_NIO_SSL: 1
       timeout-minutes: 20
       timeout-minutes: 20
     - name: Test without NIOSSL
     - name: Test without NIOSSL
-      # Skip tests on 5.6: https://bugs.swift.org/browse/SR-15955
-      if: ${{ matrix.image != 'swift:5.6-focal' }}
       run: swift test --enable-test-discovery
       run: swift test --enable-test-discovery
       env:
       env:
         GRPC_NO_NIO_SSL: 1
         GRPC_NO_NIO_SSL: 1