Browse Source

Minor renaming in prototype generated code.

Tim Burks 9 years ago
parent
commit
21594bc84f

+ 7 - 5
Examples/Echo/Swift/Echo.xcodeproj/project.pbxproj

@@ -14,7 +14,7 @@
 		D35C9FAE1D74B079000443CD /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = D35C9FAD1D74B079000443CD /* Assets.xcassets */; };
 		D35C9FB11D74B079000443CD /* MainMenu.xib in Resources */ = {isa = PBXBuildFile; fileRef = D35C9FAF1D74B079000443CD /* MainMenu.xib */; };
 		D35C9FC81D74B0C1000443CD /* EchoViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D35C9FC71D74B0C1000443CD /* EchoViewController.swift */; };
-		D38F9C401E1F0D2C003DECA4 /* EchoHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = D38F9C3F1E1F0D2C003DECA4 /* EchoHandler.swift */; };
+		D38F9C401E1F0D2C003DECA4 /* EchoProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = D38F9C3F1E1F0D2C003DECA4 /* EchoProvider.swift */; };
 		D3971E211D89132E001A0B3F /* ssl.key in Resources */ = {isa = PBXBuildFile; fileRef = D3971E201D89132E001A0B3F /* ssl.key */; };
 		D3BFE28C1D87A45D00A648D8 /* ssl.crt in Resources */ = {isa = PBXBuildFile; fileRef = D3BFE28B1D87A45D00A648D8 /* ssl.crt */; };
 		D3D2EA4C1D75FB7F002EF89C /* gRPC.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = D3D2EA3E1D75FB56002EF89C /* gRPC.framework */; };
@@ -83,7 +83,7 @@
 		D35C9FB21D74B079000443CD /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
 		D35C9FC71D74B0C1000443CD /* EchoViewController.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = EchoViewController.swift; sourceTree = "<group>"; };
 		D36C3EF81E145A2200BF4EB3 /* SwiftProtobufRuntime.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = SwiftProtobufRuntime.xcodeproj; path = "../../../third_party/swift-protobuf/SwiftProtobufRuntime.xcodeproj"; sourceTree = "<group>"; };
-		D38F9C3F1E1F0D2C003DECA4 /* EchoHandler.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; lineEnding = 0; path = EchoHandler.swift; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.swift; };
+		D38F9C3F1E1F0D2C003DECA4 /* EchoProvider.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; lineEnding = 0; path = EchoProvider.swift; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.swift; };
 		D3971E201D89132E001A0B3F /* ssl.key */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ssl.key; sourceTree = "<group>"; };
 		D3BFE28B1D87A45D00A648D8 /* ssl.crt */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = ssl.crt; sourceTree = "<group>"; };
 		D3D2EA391D75FB56002EF89C /* gRPC.xcodeproj */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.pb-project"; name = gRPC.xcodeproj; path = ../../../gRPC.xcodeproj; sourceTree = "<group>"; };
@@ -135,7 +135,7 @@
 				D35C9FAD1D74B079000443CD /* Assets.xcassets */,
 				D30DACEF1DB6FC2D00886B20 /* echo.client.pb.swift */,
 				D324A6011D81CF8F00421B59 /* echo.server.pb.swift */,
-				D38F9C3F1E1F0D2C003DECA4 /* EchoHandler.swift */,
+				D38F9C3F1E1F0D2C003DECA4 /* EchoProvider.swift */,
 				D35C9FC71D74B0C1000443CD /* EchoViewController.swift */,
 				D35C9FB21D74B079000443CD /* Info.plist */,
 				D35C9FAF1D74B079000443CD /* MainMenu.xib */,
@@ -193,7 +193,7 @@
 			isa = PBXProject;
 			attributes = {
 				LastSwiftUpdateCheck = 0800;
-				LastUpgradeCheck = 0800;
+				LastUpgradeCheck = 0820;
 				ORGANIZATIONNAME = Google;
 				TargetAttributes = {
 					D35C9FA71D74B079000443CD = {
@@ -291,7 +291,7 @@
 				D30DACF01DB6FC2D00886B20 /* echo.client.pb.swift in Sources */,
 				D324A6021D81CF8F00421B59 /* echo.server.pb.swift in Sources */,
 				D35C9FC81D74B0C1000443CD /* EchoViewController.swift in Sources */,
-				D38F9C401E1F0D2C003DECA4 /* EchoHandler.swift in Sources */,
+				D38F9C401E1F0D2C003DECA4 /* EchoProvider.swift in Sources */,
 				D359A6271DBAD11C00FE6282 /* echo.pb.swift in Sources */,
 				D35C9FAC1D74B079000443CD /* AppDelegate.swift in Sources */,
 			);
@@ -342,6 +342,7 @@
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_SUSPICIOUS_MOVES = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -391,6 +392,7 @@
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_SUSPICIOUS_MOVES = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;

+ 4 - 4
Examples/Echo/Swift/Echo/AppDelegate.swift

@@ -37,18 +37,18 @@ class AppDelegate: NSObject, NSApplicationDelegate {
 
   @IBOutlet weak var window: NSWindow!
 
-  var echoHandler : EchoHandler!
+  var echoProvider : EchoProvider!
   var insecureServer: Echo_EchoServer!
   var secureServer: Echo_EchoServer!
 
   func applicationDidFinishLaunching(_ aNotification: Notification) {
 
     // instantiate our custom-written application handler
-    echoHandler = EchoHandler()
+    echoProvider = EchoProvider()
 
     // create and start a server for handling insecure requests
     insecureServer = Echo_EchoServer(address:"localhost:8081",
-                                     handler:echoHandler)
+                                     provider:echoProvider)
     insecureServer.start()
 
     // create and start a server for handling secure requests
@@ -57,7 +57,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
     secureServer = Echo_EchoServer(address:"localhost:8443",
                                    certificateURL:certificateURL,
                                    keyURL:keyURL,
-                                   handler:echoHandler)
+                                   provider:echoProvider)
     secureServer.start()
   }
 }

+ 1 - 1
Examples/Echo/Swift/Echo/EchoHandler.swift → Examples/Echo/Swift/Echo/EchoProvider.swift

@@ -33,7 +33,7 @@
 
 import Foundation
 
-class EchoHandler : Echo_EchoHandler {
+class EchoProvider : Echo_EchoProvider {
 
   // Get returns requests as they were received.
   func Get(request : Echo_EchoRequest) throws -> Echo_EchoResponse {

+ 0 - 1
Examples/Echo/Swift/Echo/EchoViewController.swift

@@ -94,7 +94,6 @@ class EchoViewController : NSViewController, NSTextFieldDelegate {
   }
 
   override func viewDidLoad() {
-    gRPC.initialize()
     closeButton.isEnabled = false
     // prevent the UI from trying to send messages until gRPC is initialized
     DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) {

+ 2 - 0
Examples/Echo/Swift/Echo/echo.client.pb.swift

@@ -272,10 +272,12 @@ public class Echo_EchoService {
   public var channel: Channel
 
   public init(address: String) {
+    gRPC.initialize()
     channel = Channel(address:address)
   }
 
   public init(address: String, certificates: String?, host: String?) {
+    gRPC.initialize()
     channel = Channel(address:address, certificates:certificates, host:host)
   }
 

+ 64 - 64
Examples/Echo/Swift/Echo/echo.server.pb.swift

@@ -40,7 +40,7 @@ public enum Echo_EchoServerError : Error {
   case endOfStream
 }
 
-public protocol Echo_EchoHandler {
+public protocol Echo_EchoProvider {
   func Get(request : Echo_EchoRequest) throws -> Echo_EchoResponse
   func Collect(session : Echo_EchoCollectSession) throws -> Void
   func Expand(request : Echo_EchoRequest, session : Echo_EchoExpandSession) throws -> Void
@@ -49,24 +49,24 @@ public protocol Echo_EchoHandler {
 
 // unary
 public class Echo_EchoGetSession {
-  var connection : gRPC.Handler
-  var handler : Echo_EchoHandler
+  var handler : gRPC.Handler
+  var provider : Echo_EchoProvider
 
-  fileprivate init(connection:gRPC.Handler, handler: Echo_EchoHandler) {
-    self.connection = connection
+  fileprivate init(handler:gRPC.Handler, provider: Echo_EchoProvider) {
     self.handler = handler
+    self.provider = provider
   }
 
   fileprivate func run(queue:DispatchQueue) {
     do {
-      try connection.receiveMessage(initialMetadata:Metadata()) {(requestData) in
+      try handler.receiveMessage(initialMetadata:Metadata()) {(requestData) in
         if let requestData = requestData {
           let requestMessage = try! Echo_EchoRequest(protobuf:requestData)
-          let replyMessage = try! self.handler.Get(request:requestMessage)
-          try self.connection.sendResponse(message:replyMessage.serializeProtobuf(),
-                                           statusCode: 0,
-                                           statusMessage: "OK",
-                                           trailingMetadata:Metadata())
+          let replyMessage = try! self.provider.Get(request:requestMessage)
+          try self.handler.sendResponse(message:replyMessage.serializeProtobuf(),
+                                        statusCode: 0,
+                                        statusMessage: "OK",
+                                        trailingMetadata:Metadata())
 
         }
       }
@@ -78,31 +78,31 @@ public class Echo_EchoGetSession {
 
 // server streaming
 public class Echo_EchoExpandSession {
-  var connection : gRPC.Handler
-  var handler : Echo_EchoHandler
+  var handler : gRPC.Handler
+  var provider : Echo_EchoProvider
 
-  fileprivate init(connection:gRPC.Handler, handler: Echo_EchoHandler) {
-    self.connection = connection
+  fileprivate init(handler:gRPC.Handler, provider: Echo_EchoProvider) {
     self.handler = handler
+    self.provider = provider
   }
 
   public func Send(_ response: Echo_EchoResponse) throws {
-    try! connection.sendResponse(message:response.serializeProtobuf()) {}
+    try! handler.sendResponse(message:response.serializeProtobuf()) {}
   }
 
   fileprivate func run(queue:DispatchQueue) {
     do {
-      try self.connection.receiveMessage(initialMetadata:Metadata()) {(requestData) in
+      try self.handler.receiveMessage(initialMetadata:Metadata()) {(requestData) in
         if let requestData = requestData {
           let requestMessage = try! Echo_EchoRequest(protobuf:requestData)
-          // to keep handlers from blocking the server thread,
+          // to keep providers from blocking the server thread,
           // we dispatch them to another queue.
           queue.async {
-            try! self.handler.Expand(request:requestMessage, session: self)
-            try! self.connection.sendStatus(statusCode:0,
-                                            statusMessage:"OK",
-                                            trailingMetadata:Metadata(),
-                                            completion:{})
+            try! self.provider.Expand(request:requestMessage, session: self)
+            try! self.handler.sendStatus(statusCode:0,
+                                         statusMessage:"OK",
+                                         trailingMetadata:Metadata(),
+                                         completion:{})
           }
         }
       }
@@ -114,19 +114,19 @@ public class Echo_EchoExpandSession {
 
 // client streaming
 public class Echo_EchoCollectSession {
-  var connection : gRPC.Handler
-  var handler : Echo_EchoHandler
+  var handler : gRPC.Handler
+  var provider : Echo_EchoProvider
 
-  fileprivate init(connection:gRPC.Handler, handler: Echo_EchoHandler) {
-    self.connection = connection
+  fileprivate init(handler:gRPC.Handler, provider: Echo_EchoProvider) {
     self.handler = handler
+    self.provider = provider
   }
 
   public func Receive() throws -> Echo_EchoRequest {
     print("collect awaiting message")
     let done = NSCondition()
     var requestMessage : Echo_EchoRequest?
-    try self.connection.receiveMessage() {(requestData) in
+    try self.handler.receiveMessage() {(requestData) in
       print("collect received message")
       if let requestData = requestData {
         requestMessage = try! Echo_EchoRequest(protobuf:requestData)
@@ -145,18 +145,18 @@ public class Echo_EchoCollectSession {
   }
 
   public func SendAndClose(_ response: Echo_EchoResponse) throws {
-    try! self.connection.sendResponse(message:response.serializeProtobuf(),
-                                      statusCode: 0,
-                                      statusMessage: "OK",
-                                      trailingMetadata: Metadata())
+    try! self.handler.sendResponse(message:response.serializeProtobuf(),
+                                   statusCode: 0,
+                                   statusMessage: "OK",
+                                   trailingMetadata: Metadata())
   }
 
   fileprivate func run(queue:DispatchQueue) {
     do {
       print("EchoCollectSession run")
-      try self.connection.sendMetadata(initialMetadata:Metadata()) {
+      try self.handler.sendMetadata(initialMetadata:Metadata()) {
         queue.async {
-          try! self.handler.Collect(session:self)
+          try! self.provider.Collect(session:self)
         }
       }
     } catch (let callError) {
@@ -167,19 +167,19 @@ public class Echo_EchoCollectSession {
 
 // fully streaming
 public class Echo_EchoUpdateSession {
-  var connection : gRPC.Handler
-  var handler : Echo_EchoHandler
+  var handler : gRPC.Handler
+  var provider : Echo_EchoProvider
 
-  fileprivate init(connection:gRPC.Handler, handler: Echo_EchoHandler) {
-    self.connection = connection
+  fileprivate init(handler:gRPC.Handler, provider: Echo_EchoProvider) {
     self.handler = handler
+    self.provider = provider
   }
 
   public func Receive() throws -> Echo_EchoRequest {
     print("update awaiting message")
     let done = NSCondition()
     var requestMessage : Echo_EchoRequest?
-    try self.connection.receiveMessage() {(requestData) in
+    try self.handler.receiveMessage() {(requestData) in
       print("update received message")
       if let requestData = requestData {
         requestMessage = try! Echo_EchoRequest(protobuf:requestData)
@@ -198,17 +198,17 @@ public class Echo_EchoUpdateSession {
   }
 
   public func Send(_ response: Echo_EchoResponse) throws {
-    try connection.sendResponse(message:response.serializeProtobuf()) {}
+    try handler.sendResponse(message:response.serializeProtobuf()) {}
   }
 
   public func Close() {
     let done = NSCondition()
-    try! self.connection.sendStatus(statusCode: 0,
-                                    statusMessage: "OK",
-                                    trailingMetadata: Metadata()) {
-                                      done.lock()
-                                      done.signal()
-                                      done.unlock()
+    try! self.handler.sendStatus(statusCode: 0,
+                                 statusMessage: "OK",
+                                 trailingMetadata: Metadata()) {
+                                  done.lock()
+                                  done.signal()
+                                  done.unlock()
     }
     done.lock()
     done.wait()
@@ -217,9 +217,9 @@ public class Echo_EchoUpdateSession {
 
   fileprivate func run(queue:DispatchQueue) {
     do {
-      try self.connection.sendMetadata(initialMetadata:Metadata()) {
+      try self.handler.sendMetadata(initialMetadata:Metadata()) {
         queue.async {
-          try! self.handler.Update(session:self)
+          try! self.provider.Update(session:self)
         }
       }
     } catch (let callError) {
@@ -234,23 +234,23 @@ public class Echo_EchoUpdateSession {
 public class Echo_EchoServer {
   private var address: String
   private var server: gRPC.Server
-  public var handler: Echo_EchoHandler!
+  public var provider: Echo_EchoProvider?
 
   public init(address:String,
-              handler:Echo_EchoHandler) {
+              provider:Echo_EchoProvider) {
     gRPC.initialize()
     self.address = address
-    self.handler = handler
+    self.provider = provider
     self.server = gRPC.Server(address:address)
   }
 
   public init?(address:String,
                certificateURL:URL,
                keyURL:URL,
-               handler:Echo_EchoHandler) {
+               provider:Echo_EchoProvider) {
     gRPC.initialize()
     self.address = address
-    self.handler = handler
+    self.provider = provider
     guard
       let certificate = try? String(contentsOf: certificateURL),
       let key = try? String(contentsOf: keyURL)
@@ -261,23 +261,23 @@ public class Echo_EchoServer {
   }
 
   public func start(queue:DispatchQueue = DispatchQueue.global()) {
-    guard let handler = self.handler else {
-      assert(false) // the server requires a handler
+    guard let provider = self.provider else {
+      assert(false) // the server requires a provider
     }
-    server.run {(connection) in
-      print("Server received request to " + connection.host
-        + " calling " + connection.method
-        + " from " + connection.caller)
+    server.run {(handler) in
+      print("Server received request to " + handler.host
+        + " calling " + handler.method
+        + " from " + handler.caller)
 
-      switch connection.method {
+      switch handler.method {
       case "/echo.Echo/Get":
-        Echo_EchoGetSession(connection:connection, handler:handler).run(queue:queue)
+        Echo_EchoGetSession(handler:handler, provider:provider).run(queue:queue)
       case "/echo.Echo/Expand":
-        Echo_EchoExpandSession(connection:connection, handler:handler).run(queue:queue)
+        Echo_EchoExpandSession(handler:handler, provider:provider).run(queue:queue)
       case "/echo.Echo/Collect":
-        Echo_EchoCollectSession(connection:connection, handler:handler).run(queue:queue)
+        Echo_EchoCollectSession(handler:handler, provider:provider).run(queue:queue)
       case "/echo.Echo/Update":
-        Echo_EchoUpdateSession(connection:connection, handler:handler).run(queue:queue)
+        Echo_EchoUpdateSession(handler:handler, provider:provider).run(queue:queue)
       default:
         break // handle unknown requests
       }

+ 5 - 1
gRPC.xcodeproj/project.pbxproj

@@ -198,7 +198,7 @@
 		D3BD372A1D5126380005E698 /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 0800;
+				LastUpgradeCheck = 0820;
 				ORGANIZATIONNAME = Google;
 				TargetAttributes = {
 					D3BD37321D5126380005E698 = {
@@ -288,8 +288,10 @@
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
+				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_IDENTITY = "-";
@@ -339,8 +341,10 @@
 				CLANG_WARN_DOCUMENTATION_COMMENTS = YES;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
+				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				CODE_SIGN_IDENTITY = "-";