Browse Source

Marked the properties as atomic, since that is what they were by default.

August Mueller 13 years ago
parent
commit
de5bff459d
5 changed files with 18 additions and 16 deletions
  1. 2 0
      fmdb.xcodeproj/project.pbxproj
  2. 9 9
      src/FMDatabase.h
  3. 3 3
      src/FMDatabasePool.h
  4. 1 1
      src/FMDatabaseQueue.h
  5. 3 3
      src/FMResultSet.h

+ 2 - 0
fmdb.xcodeproj/project.pbxproj

@@ -276,6 +276,7 @@
 				CLANG_ENABLE_OBJC_ARC = YES;
 				CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;
 				CLANG_WARN_OBJCPP_ARC_ABI = YES;
+				CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
 				CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
 				COPY_PHASE_STRIP = NO;
 				GCC_DYNAMIC_NO_PIC = NO;
@@ -298,6 +299,7 @@
 				CLANG_ENABLE_OBJC_ARC = YES;
 				CLANG_WARN_IMPLICIT_SIGN_CONVERSION = YES;
 				CLANG_WARN_OBJCPP_ARC_ABI = YES;
+				CLANG_WARN_OBJC_IMPLICIT_ATOMIC_PROPERTIES = YES;
 				CLANG_WARN_SUSPICIOUS_IMPLICIT_CONVERSION = YES;
 				GCC_GENERATE_DEBUGGING_SYMBOLS = NO;
 				GCC_MODEL_TUNING = G5;

+ 9 - 9
src/FMDatabase.h

@@ -44,12 +44,12 @@
 }
 
 
-@property (assign) BOOL traceExecution;
-@property (assign) BOOL checkedOut;
-@property (assign) int busyRetryTimeout;
-@property (assign) BOOL crashOnErrors;
-@property (assign) BOOL logsErrors;
-@property (retain) NSMutableDictionary *cachedStatements;
+@property (atomic, assign) BOOL traceExecution;
+@property (atomic, assign) BOOL checkedOut;
+@property (atomic, assign) int busyRetryTimeout;
+@property (atomic, assign) BOOL crashOnErrors;
+@property (atomic, assign) BOOL logsErrors;
+@property (atomic, retain) NSMutableDictionary *cachedStatements;
 
 
 + (id)databaseWithPath:(NSString*)inPath;
@@ -122,9 +122,9 @@
     long _useCount;
 }
 
-@property (assign) long useCount;
-@property (retain) NSString *query;
-@property (assign) sqlite3_stmt *statement;
+@property (atomic, assign) long useCount;
+@property (atomic, retain) NSString *query;
+@property (atomic, assign) sqlite3_stmt *statement;
 
 - (void)close;
 - (void)reset;

+ 3 - 3
src/FMDatabasePool.h

@@ -41,9 +41,9 @@ in the main.m file.
     NSUInteger          _maximumNumberOfDatabasesToCreate;
 }
 
-@property (retain) NSString *path;
-@property (assign) id delegate;
-@property (assign) NSUInteger maximumNumberOfDatabasesToCreate;
+@property (atomic, retain) NSString *path;
+@property (atomic, assign) id delegate;
+@property (atomic, assign) NSUInteger maximumNumberOfDatabasesToCreate;
 
 + (id)databasePoolWithPath:(NSString*)aPath;
 - (id)initWithPath:(NSString*)aPath;

+ 1 - 1
src/FMDatabaseQueue.h

@@ -17,7 +17,7 @@
     FMDatabase          *_db;
 }
 
-@property (retain) NSString *path;
+@property (atomic, retain) NSString *path;
 
 + (id)databaseQueueWithPath:(NSString*)aPath;
 - (id)initWithPath:(NSString*)aPath;

+ 3 - 3
src/FMResultSet.h

@@ -25,9 +25,9 @@
     BOOL                _columnNamesSetup;
 }
 
-@property (retain) NSString *query;
-@property (retain) NSMutableDictionary *columnNameToIndexMap;
-@property (retain) FMStatement *statement;
+@property (atomic, retain) NSString *query;
+@property (atomic, retain) NSMutableDictionary *columnNameToIndexMap;
+@property (atomic, retain) FMStatement *statement;
 
 + (id)resultSetWithStatement:(FMStatement *)statement usingParentDatabase:(FMDatabase*)aDB;