Browse Source

More notes to self.

ccgus 12 years ago
parent
commit
99bf192e1e
1 changed files with 2 additions and 2 deletions
  1. 2 2
      Tests/FMDatabasePoolTests.m

+ 2 - 2
Tests/FMDatabasePoolTests.m

@@ -255,8 +255,8 @@ - (void)testStressTest
 
 - (BOOL)databasePool:(FMDatabasePool*)pool shouldAddDatabaseToPool:(FMDatabase*)database {
     [database setRetryTimeout:.1];
-    [database setCrashOnErrors:YES];
-    #pragma message "FIXME: Gus - we need to check for a SQLITE_BUSY when we call sqlite3_step.  sqlite will sleep for the retry amount - BUT, it won't just try the step again.  We'll have to put the old loops back in.  testReadWriteStressTest shows this mistake."
+    // [database setCrashOnErrors:YES];
+    #pragma message "FIXME: Gus - we need to check for a SQLITE_BUSY when we call sqlite3_step.  sqlite will sleep for the retry amount - BUT, it won't just try the step again.  We'll have to put the old loops back in.  testReadWriteStressTest shows this mistake.  Maybe add a private method to FMDatabase that does the stepping and loop for us, and replace sqlite3_step with that?"
     return YES;
 }