ImageDownloaderTests.swift 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603
  1. //
  2. // ImageDownloaderTests.swift
  3. // Kingfisher
  4. //
  5. // Created by Wei Wang on 15/4/10.
  6. //
  7. // Copyright (c) 2019 Wei Wang <onevcat@gmail.com>
  8. //
  9. // Permission is hereby granted, free of charge, to any person obtaining a copy
  10. // of this software and associated documentation files (the "Software"), to deal
  11. // in the Software without restriction, including without limitation the rights
  12. // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  13. // copies of the Software, and to permit persons to whom the Software is
  14. // furnished to do so, subject to the following conditions:
  15. //
  16. // The above copyright notice and this permission notice shall be included in
  17. // all copies or substantial portions of the Software.
  18. //
  19. // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  20. // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  21. // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  22. // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  23. // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  24. // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  25. // THE SOFTWARE.
  26. import XCTest
  27. @testable import Kingfisher
  28. class ImageDownloaderTests: XCTestCase {
  29. var downloader: ImageDownloader!
  30. var modifier = URLModifier()
  31. override class func setUp() {
  32. super.setUp()
  33. LSNocilla.sharedInstance().start()
  34. }
  35. override class func tearDown() {
  36. LSNocilla.sharedInstance().stop()
  37. super.tearDown()
  38. }
  39. override func setUp() {
  40. super.setUp()
  41. downloader = ImageDownloader(name: "test")
  42. }
  43. override func tearDown() {
  44. LSNocilla.sharedInstance().clearStubs()
  45. downloader = nil
  46. super.tearDown()
  47. }
  48. func testDownloadAnImage() {
  49. let exp = expectation(description: #function)
  50. let url = testURLs[0]
  51. stub(url, data: testImageData)
  52. downloader.downloadImage(with: url) { result in
  53. XCTAssertNotNil(result.value)
  54. exp.fulfill()
  55. }
  56. waitForExpectations(timeout: 3, handler: nil)
  57. }
  58. func testDownloadMultipleImages() {
  59. let exp = expectation(description: #function)
  60. let group = DispatchGroup()
  61. for url in testURLs {
  62. group.enter()
  63. stub(url, data: testImageData)
  64. downloader.downloadImage(with: url) { result in
  65. XCTAssertNotNil(result.value)
  66. group.leave()
  67. }
  68. }
  69. group.notify(queue: .main, execute: exp.fulfill)
  70. waitForExpectations(timeout: 3, handler: nil)
  71. }
  72. func testDownloadAnImageWithMultipleCallback() {
  73. let exp = expectation(description: #function)
  74. let group = DispatchGroup()
  75. let url = testURLs[0]
  76. stub(url, data: testImageData)
  77. for _ in 0...5 {
  78. group.enter()
  79. downloader.downloadImage(with: url) { result in
  80. XCTAssertNotNil(result.value)
  81. group.leave()
  82. }
  83. }
  84. group.notify(queue: .main, execute: exp.fulfill)
  85. waitForExpectations(timeout: 5, handler: nil)
  86. }
  87. func testDownloadWithModifyingRequest() {
  88. let exp = expectation(description: #function)
  89. let url = testURLs[0]
  90. stub(url, data: testImageData)
  91. modifier.url = url
  92. let someURL = URL(string: "some_strange_url")!
  93. let task = downloader.downloadImage(with: someURL, options: [.requestModifier(modifier)]) { result in
  94. XCTAssertNotNil(result.value)
  95. XCTAssertEqual(result.value?.url, url)
  96. exp.fulfill()
  97. }
  98. XCTAssertNotNil(task)
  99. waitForExpectations(timeout: 3, handler: nil)
  100. }
  101. func testDownloadWithAsyncModifyingRequest() {
  102. let exp = expectation(description: #function)
  103. let url = testURLs[0]
  104. stub(url, data: testImageData)
  105. var downloadTaskCalled = false
  106. let asyncModifier = AsyncURLModifier()
  107. asyncModifier.url = url
  108. asyncModifier.onDownloadTaskStarted = { task in
  109. XCTAssertNotNil(task)
  110. downloadTaskCalled = true
  111. }
  112. let someURL = URL(string: "some_strage_url")!
  113. let task = downloader.downloadImage(with: someURL, options: [.requestModifier(asyncModifier)]) { result in
  114. XCTAssertNotNil(result.value)
  115. XCTAssertEqual(result.value?.url, url)
  116. XCTAssertTrue(downloadTaskCalled)
  117. exp.fulfill()
  118. }
  119. // The returned task is nil since the download is not starting immediately.
  120. XCTAssertNil(task)
  121. waitForExpectations(timeout: 3, handler: nil)
  122. }
  123. func testDownloadWithModifyingRequestToNil() {
  124. let nilModifier = AnyModifier { _ in
  125. return nil
  126. }
  127. let exp = expectation(description: #function)
  128. let someURL = URL(string: "some_strange_url")!
  129. downloader.downloadImage(with: someURL, options: [.requestModifier(nilModifier)]) { result in
  130. XCTAssertNotNil(result.error)
  131. guard case .requestError(reason: .emptyRequest) = result.error! else {
  132. XCTFail()
  133. fatalError()
  134. }
  135. exp.fulfill()
  136. }
  137. waitForExpectations(timeout: 3, handler: nil)
  138. }
  139. func testServerInvalidStatusCode() {
  140. let exp = expectation(description: #function)
  141. let url = testURLs[0]
  142. stub(url, data: testImageData, statusCode: 404)
  143. downloader.downloadImage(with: url) { result in
  144. XCTAssertNotNil(result.error)
  145. XCTAssertTrue(result.error!.isInvalidResponseStatusCode(404))
  146. exp.fulfill()
  147. }
  148. waitForExpectations(timeout: 3, handler: nil)
  149. }
  150. func testDownloadResultErrorAndRetry() {
  151. let exp = expectation(description: #function)
  152. let url = testURLs[0]
  153. stub(url, errorCode: -1)
  154. downloader.downloadImage(with: url) { result in
  155. XCTAssertNotNil(result.error)
  156. LSNocilla.sharedInstance().clearStubs()
  157. stub(url, data: testImageData)
  158. // Retry the download
  159. self.downloader.downloadImage(with: url) { result in
  160. XCTAssertNil(result.error)
  161. exp.fulfill()
  162. }
  163. }
  164. waitForExpectations(timeout: 3, handler: nil)
  165. }
  166. func testDownloadEmptyURL() {
  167. let exp = expectation(description: #function)
  168. modifier.url = nil
  169. let url = URL(string: "http://onevcat.com")!
  170. downloader.downloadImage(
  171. with: url,
  172. options: [.requestModifier(modifier)],
  173. progressBlock: { received, totalSize in XCTFail("The progress block should not be called.") })
  174. {
  175. result in
  176. XCTAssertNotNil(result.error)
  177. if case .requestError(reason: .invalidURL(let request)) = result.error! {
  178. XCTAssertNil(request.url)
  179. } else {
  180. XCTFail()
  181. }
  182. exp.fulfill()
  183. }
  184. waitForExpectations(timeout: 3, handler: nil)
  185. }
  186. func testDownloadTaskProperty() {
  187. let task = downloader.downloadImage(with: URL(string: "1234")!)
  188. XCTAssertNotNil(task, "The task should exist.")
  189. }
  190. func testCancelDownloadTask() {
  191. let exp = expectation(description: #function)
  192. let url = testURLs[0]
  193. let stub = delayedStub(url, data: testImageData, length: 123)
  194. let task = downloader.downloadImage(
  195. with: url,
  196. progressBlock: { _, _ in XCTFail() })
  197. {
  198. result in
  199. XCTAssertNotNil(result.error)
  200. XCTAssertTrue(result.error!.isTaskCancelled)
  201. delay(0.1) { exp.fulfill() }
  202. }
  203. XCTAssertNotNil(task)
  204. task!.cancel()
  205. _ = stub.go()
  206. waitForExpectations(timeout: 3, handler: nil)
  207. }
  208. func testCancelOneDownloadTask() {
  209. let exp = expectation(description: #function)
  210. let url = testURLs[0]
  211. let stub = delayedStub(url, data: testImageData)
  212. let group = DispatchGroup()
  213. group.enter()
  214. let task1 = downloader.downloadImage(with: url) { result in
  215. XCTAssertNotNil(result.error)
  216. group.leave()
  217. }
  218. group.enter()
  219. _ = downloader.downloadImage(with: url) { result in
  220. XCTAssertNotNil(result.value?.image)
  221. group.leave()
  222. }
  223. task1?.cancel()
  224. delay(0.1) { _ = stub.go() }
  225. group.notify(queue: .main) {
  226. delay(0.1) { exp.fulfill() }
  227. }
  228. waitForExpectations(timeout: 3, handler: nil)
  229. }
  230. func testCancelAllDownloadTasks() {
  231. let exp = expectation(description: #function)
  232. let url1 = testURLs[0]
  233. let stub1 = delayedStub(url1, data: testImageData)
  234. let url2 = testURLs[1]
  235. let stub2 = delayedStub(url2, data: testImageData)
  236. let group = DispatchGroup()
  237. let urls = [url1, url1, url2]
  238. urls.forEach {
  239. group.enter()
  240. downloader.downloadImage(with: $0) { result in
  241. XCTAssertNotNil(result.error)
  242. XCTAssertTrue(result.error!.isTaskCancelled)
  243. group.leave()
  244. }
  245. }
  246. delay(0.1) {
  247. self.downloader.cancelAll()
  248. _ = stub1.go()
  249. _ = stub2.go()
  250. }
  251. group.notify(queue: .main) {
  252. delay(0.1) { exp.fulfill() }
  253. }
  254. waitForExpectations(timeout: 3, handler: nil)
  255. }
  256. func testCancelDownloadTaskForURL() {
  257. let exp = expectation(description: #function)
  258. let url1 = testURLs[0]
  259. let stub1 = delayedStub(url1, data: testImageData)
  260. let url2 = testURLs[1]
  261. let stub2 = delayedStub(url2, data: testImageData)
  262. let group = DispatchGroup()
  263. group.enter()
  264. downloader.downloadImage(with: url1) { result in
  265. XCTAssertNotNil(result.error)
  266. XCTAssertTrue(result.error!.isTaskCancelled)
  267. group.leave()
  268. }
  269. group.enter()
  270. downloader.downloadImage(with: url1) { result in
  271. XCTAssertNotNil(result.error)
  272. XCTAssertTrue(result.error!.isTaskCancelled)
  273. group.leave()
  274. }
  275. group.enter()
  276. downloader.downloadImage(with: url2) { result in
  277. XCTAssertNotNil(result.value)
  278. group.leave()
  279. }
  280. delay(0.1) {
  281. self.downloader.cancel(url: url1)
  282. _ = stub1.go()
  283. _ = stub2.go()
  284. }
  285. group.notify(queue: .main) {
  286. delay(0.1) { exp.fulfill() }
  287. }
  288. waitForExpectations(timeout: 3, handler: nil)
  289. }
  290. // Issue 532 https://github.com/onevcat/Kingfisher/issues/532#issuecomment-305644311
  291. func testCancelThenRestartSameDownload() {
  292. let exp = expectation(description: #function)
  293. let url = testURLs[0]
  294. let stub = delayedStub(url, data: testImageData, length: 123)
  295. let group = DispatchGroup()
  296. group.enter()
  297. let downloadTask = downloader.downloadImage(
  298. with: url,
  299. progressBlock: { _, _ in XCTFail()})
  300. {
  301. result in
  302. XCTAssertNotNil(result.error)
  303. XCTAssertTrue(result.error!.isTaskCancelled)
  304. group.leave()
  305. }
  306. XCTAssertNotNil(downloadTask)
  307. downloadTask!.cancel()
  308. _ = stub.go()
  309. group.enter()
  310. downloader.downloadImage(with: url) {
  311. result in
  312. XCTAssertNotNil(result.value)
  313. if let error = result.error {
  314. print(error)
  315. }
  316. group.leave()
  317. }
  318. group.notify(queue: .main) {
  319. delay(0.1) { exp.fulfill() }
  320. }
  321. waitForExpectations(timeout: 3, handler: nil)
  322. }
  323. func testDownloadTaskNil() {
  324. modifier.url = nil
  325. let downloadTask = downloader.downloadImage(with: URL(string: "url")!, options: [.requestModifier(modifier)])
  326. XCTAssertNil(downloadTask)
  327. }
  328. func testDownloadWithProcessor() {
  329. let exp = expectation(description: #function)
  330. let url = testURLs[0]
  331. stub(url, data: testImageData)
  332. let p = RoundCornerImageProcessor(cornerRadius: 40)
  333. let roundcornered = testImage.kf.image(withRoundRadius: 40, fit: testImage.kf.size)
  334. downloader.downloadImage(with: url, options: [.processor(p)]) { result in
  335. XCTAssertNotNil(result.value)
  336. let image = result.value!.image
  337. XCTAssertFalse(image.renderEqual(to: testImage))
  338. XCTAssertTrue(image.renderEqual(to: roundcornered))
  339. XCTAssertEqual(result.value!.originalData, testImageData)
  340. exp.fulfill()
  341. }
  342. waitForExpectations(timeout: 3, handler: nil)
  343. }
  344. func testDownloadWithDifferentProcessors() {
  345. let exp = expectation(description: #function)
  346. let url = testURLs[0]
  347. let stub = delayedStub(url, data: testImageData)
  348. let p1 = RoundCornerImageProcessor(cornerRadius: 40)
  349. let roundcornered = testImage.kf.image(withRoundRadius: 40, fit: testImage.kf.size)
  350. let p2 = BlurImageProcessor(blurRadius: 3.0)
  351. let blurred = testImage.kf.blurred(withRadius: 3.0)
  352. let group = DispatchGroup()
  353. group.enter()
  354. let task1 = downloader.downloadImage(with: url, options: [.processor(p1)]) { result in
  355. XCTAssertTrue(result.value!.image.renderEqual(to: roundcornered))
  356. group.leave()
  357. }
  358. group.enter()
  359. let task2 = downloader.downloadImage(with: url, options: [.processor(p2)]) { result in
  360. XCTAssertTrue(result.value!.image.renderEqual(to: blurred))
  361. group.leave()
  362. }
  363. XCTAssertNotNil(task1)
  364. XCTAssertEqual(task1?.sessionTask.task, task2?.sessionTask.task)
  365. _ = stub.go()
  366. group.notify(queue: .main, execute: exp.fulfill)
  367. waitForExpectations(timeout: 3, handler: nil)
  368. }
  369. func testDownloadedDataCouldBeModified() {
  370. let exp = expectation(description: #function)
  371. let url = testURLs[0]
  372. stub(url, data: testImageData)
  373. let modifier = URLNilDataModifier()
  374. downloader.delegate = modifier
  375. downloader.downloadImage(with: url) { result in
  376. XCTAssertNil(result.value)
  377. XCTAssertNotNil(result.error)
  378. if case .responseError(reason: .dataModifyingFailed) = result.error! {
  379. } else {
  380. XCTFail()
  381. }
  382. self.downloader.delegate = nil
  383. // hold delegate
  384. _ = modifier
  385. exp.fulfill()
  386. }
  387. waitForExpectations(timeout: 3, handler: nil)
  388. }
  389. func testDownloadedDataCouldBeModifiedWithTask() {
  390. let exp = expectation(description: #function)
  391. let url = testURLs[0]
  392. stub(url, data: testImageData)
  393. let modifier = TaskNilDataModifier()
  394. downloader.delegate = modifier
  395. downloader.downloadImage(with: url) { result in
  396. XCTAssertNil(result.value)
  397. XCTAssertNotNil(result.error)
  398. if case .responseError(reason: .dataModifyingFailed) = result.error! {
  399. } else {
  400. XCTFail()
  401. }
  402. self.downloader.delegate = nil
  403. // hold delegate
  404. _ = modifier
  405. exp.fulfill()
  406. }
  407. waitForExpectations(timeout: 3, handler: nil)
  408. }
  409. #if os(iOS) || os(tvOS) || os(watchOS)
  410. func testModifierShouldOnlyApplyForFinalResultWhenDownload() {
  411. let exp = expectation(description: #function)
  412. let url = testURLs[0]
  413. stub(url, data: testImageData)
  414. var modifierCalled = false
  415. let modifier = AnyImageModifier { image in
  416. modifierCalled = true
  417. return image.withRenderingMode(.alwaysTemplate)
  418. }
  419. downloader.downloadImage(with: url, options: [.imageModifier(modifier)]) { result in
  420. XCTAssertFalse(modifierCalled)
  421. XCTAssertEqual(result.value?.image.renderingMode, .automatic)
  422. exp.fulfill()
  423. }
  424. waitForExpectations(timeout: 3, handler: nil)
  425. }
  426. #endif
  427. func testDownloadTaskTakePriorityOption() {
  428. let exp = expectation(description: #function)
  429. let url = testURLs[0]
  430. stub(url, data: testImageData)
  431. let task = downloader.downloadImage(with: url, options: [.downloadPriority(URLSessionTask.highPriority)])
  432. {
  433. _ in
  434. exp.fulfill()
  435. }
  436. XCTAssertEqual(task?.sessionTask.task.priority, URLSessionTask.highPriority)
  437. waitForExpectations(timeout: 3, handler: nil)
  438. }
  439. func testSessionDelegate() {
  440. class ExtensionDelegate:SessionDelegate {
  441. //'exp' only for test
  442. public let exp:XCTestExpectation
  443. init(_ expectation:XCTestExpectation) {
  444. exp = expectation
  445. }
  446. func urlSession(_ session: URLSession, task: URLSessionTask, didFinishCollecting metrics: URLSessionTaskMetrics) {
  447. exp.fulfill()
  448. }
  449. }
  450. downloader.sessionDelegate = ExtensionDelegate(expectation(description: #function))
  451. let url = testURLs[0]
  452. stub(url, data: testImageData)
  453. downloader.downloadImage(with: url) { result in
  454. XCTAssertNotNil(result.value)
  455. }
  456. waitForExpectations(timeout: 3, handler: nil)
  457. }
  458. }
  459. class URLNilDataModifier: ImageDownloaderDelegate {
  460. func imageDownloader(_ downloader: ImageDownloader, didDownload data: Data, for url: URL) -> Data? {
  461. return nil
  462. }
  463. }
  464. class TaskNilDataModifier: ImageDownloaderDelegate {
  465. func imageDownloader(_ downloader: ImageDownloader, didDownload data: Data, with dataTask: SessionDataTask) -> Data? {
  466. return nil
  467. }
  468. }
  469. class URLModifier: ImageDownloadRequestModifier {
  470. var url: URL? = nil
  471. func modified(for request: URLRequest) -> URLRequest? {
  472. var r = request
  473. r.url = url
  474. return r
  475. }
  476. }
  477. class AsyncURLModifier: AsyncImageDownloadRequestModifier {
  478. var url: URL? = nil
  479. var onDownloadTaskStarted: ((DownloadTask?) -> Void)?
  480. func modified(for request: URLRequest, reportModified: @escaping (URLRequest?) -> Void) {
  481. var r = request
  482. r.url = url
  483. DispatchQueue.main.async {
  484. reportModified(r)
  485. }
  486. }
  487. }