Ver Fonte

Unpublic data receiving side effect changes for now

onevcat há 6 anos atrás
pai
commit
c96c7a9718

+ 2 - 5
Sources/General/KingfisherOptionsInfo.swift

@@ -216,8 +216,6 @@ public enum KingfisherOptionsInfoItem {
     
     /// Enable progressive image loading, Kingfisher will use the `ImageProgressive` of
     case progressiveJPEG(ImageProgressive)
-
-    case onDataReceived([DataReceivingSideEffect])
 }
 
 // Improve performance by parsing the input `KingfisherOptionsInfo` (self) first.
@@ -258,7 +256,7 @@ public struct KingfisherParsedOptionsInfo {
     public var processingQueue: CallbackQueue? = nil
     public var progressiveJPEG: ImageProgressive? = nil
 
-    public var onDataReceived: [DataReceivingSideEffect]? = nil
+    var onDataReceived: [DataReceivingSideEffect]? = nil
     
     public init(_ info: KingfisherOptionsInfo?) {
         guard let info = info else { return }
@@ -295,7 +293,6 @@ public struct KingfisherParsedOptionsInfo {
             case .diskCacheExpiration(let expiration): diskCacheExpiration = expiration
             case .processingQueue(let queue): processingQueue = queue
             case .progressiveJPEG(let value): progressiveJPEG = value
-            case .onDataReceived(let value): onDataReceived = value
             }
         }
 
@@ -315,7 +312,7 @@ extension KingfisherParsedOptionsInfo {
     }
 }
 
-public protocol DataReceivingSideEffect: AnyObject {
+protocol DataReceivingSideEffect: AnyObject {
     var onShouldApply: () -> Bool { get set }
     func onDataReceived(_ session: URLSession, task: SessionDataTask, data: Data)
 }

+ 4 - 4
Tests/KingfisherTests/DataReceivingSideEffectTests.swift

@@ -59,14 +59,14 @@ class DataReceivingSideEffectTests: XCTestCase {
         super.tearDown()
     }
 
-    func testDataReceivingSideEffectBlockCanBeCalled() {
+    func xtestDataReceivingSideEffectBlockCanBeCalled() {
         let exp = expectation(description: #function)
         let url = testURLs[0]
         stub(url, data: testImageData, length: 123)
 
         let receiver = DataReceivingStub()
 
-        let options: KingfisherOptionsInfo = [.onDataReceived([receiver]), .waitForCache]
+        let options: KingfisherOptionsInfo = [/*.onDataReceived([receiver]),*/ .waitForCache]
         KingfisherManager.shared.retrieveImage(with: url, options: options) {
             result in
             XCTAssertTrue(receiver.called)
@@ -75,14 +75,14 @@ class DataReceivingSideEffectTests: XCTestCase {
         waitForExpectations(timeout: 3, handler: nil)
     }
 
-    func testDataReceivingSideEffectBlockCanBeCalledButNotApply() {
+    func xtestDataReceivingSideEffectBlockCanBeCalledButNotApply() {
         let exp = expectation(description: #function)
         let url = testURLs[0]
         stub(url, data: testImageData, length: 123)
 
         let receiver = DataReceivingNotAppyStub()
 
-        let options: KingfisherOptionsInfo = [.onDataReceived([receiver]), .waitForCache]
+        let options: KingfisherOptionsInfo = [/*.onDataReceived([receiver]),*/ .waitForCache]
         KingfisherManager.shared.retrieveImage(with: url, options: options) {
             result in
             XCTAssertTrue(receiver.called)