Browse Source

Merge pull request #1537 from Statsminizzle/bugfix/cancel_crash

Cancel moved to avoid crash
Wei Wang 5 years ago
parent
commit
93217580e2

+ 0 - 3
Sources/Networking/SessionDataTask.swift

@@ -101,9 +101,6 @@ public class SessionDataTask {
         guard let callback = removeCallback(token) else {
         guard let callback = removeCallback(token) else {
             return
             return
         }
         }
-        if callbacksStore.count == 0 {
-            task.cancel()
-        }
         onCallbackCancelled.call((token, callback))
         onCallbackCancelled.call((token, callback))
     }
     }
 
 

+ 1 - 0
Sources/Networking/SessionDelegate.swift

@@ -73,6 +73,7 @@ class SessionDelegate: NSObject {
             // No other callbacks waiting, we can clear the task now.
             // No other callbacks waiting, we can clear the task now.
             if !task.containsCallbacks {
             if !task.containsCallbacks {
                 let dataTask = task.task
                 let dataTask = task.task
+                dataTask.cancel()
                 self.remove(dataTask)
                 self.remove(dataTask)
             }
             }
         }
         }