Browse Source

modify: Modified to apply the default placehoder even when a task fails

Hyosung 3 years ago
parent
commit
8b138733e5

+ 1 - 1
Sources/Extensions/CPListItem+Kingfisher.swift

@@ -203,7 +203,7 @@ extension KingfisherWrapper where Base: CPListItem {
                                 
                             } else {
                                 #if compiler(>=5.4)
-                                self.base.setImage(nil)
+                                self.base.setImage(placeholder)
                                 #endif
                             }
                             completionHandler?(result)

+ 2 - 0
Sources/Extensions/ImageView+Kingfisher.swift

@@ -354,6 +354,8 @@ extension KingfisherWrapper where Base: KFCrossPlatformImageView {
                         if let image = options.onFailureImage {
                             mutatingSelf.placeholder = nil
                             self.base.image = image
+                        } else {
+                          mutatingSelf.placeholder = placeholder
                         }
                         completionHandler?(result)
                     }

+ 2 - 0
Sources/Extensions/NSButton+Kingfisher.swift

@@ -157,6 +157,8 @@ extension KingfisherWrapper where Base: NSButton {
                     case .failure:
                         if let image = options.onFailureImage {
                             self.base.image = image
+                        } else {
+                          self.base.image = placeholder
                         }
                         completionHandler?(result)
                     }

+ 2 - 0
Sources/Extensions/NSTextAttachment+Kingfisher.swift

@@ -225,6 +225,8 @@ extension KingfisherWrapper where Base: NSTextAttachment {
                     case .failure:
                         if let image = options.onFailureImage {
                             self.base.image = image
+                        } else {
+                          self.base.image = placeholder
                         }
                     }
                     completionHandler?(result)

+ 2 - 0
Sources/Extensions/TVMonogramView+Kingfisher.swift

@@ -129,6 +129,8 @@ extension KingfisherWrapper where Base: TVMonogramView {
                     case .failure:
                         if let image = options.onFailureImage {
                             self.base.image = image
+                        } else {
+                          self.base.image = placeholder
                         }
                         completionHandler?(result)
                     }

+ 2 - 0
Sources/Extensions/UIButton+Kingfisher.swift

@@ -165,6 +165,8 @@ extension KingfisherWrapper where Base: UIButton {
                     case .failure:
                         if let image = options.onFailureImage {
                             self.base.setImage(image, for: state)
+                        } else {
+                          self.base.setImage(placeholder, for: state)
                         }
                         completionHandler?(result)
                     }

+ 2 - 0
Sources/Extensions/WKInterfaceImage+Kingfisher.swift

@@ -159,6 +159,8 @@ extension KingfisherWrapper where Base: WKInterfaceImage {
                     case .failure:
                         if let image = options.onFailureImage {
                             self.base.setImage(image)
+                        } else {
+                          self.base.setImage(placeholder)
                         }
                         completionHandler?(result)
                     }