Browse Source

Minor cleanup

Marcin Krzyżanowski 10 years ago
parent
commit
674cc15c32
3 changed files with 4 additions and 8 deletions
  1. 2 4
      CryptoSwift/AES.swift
  2. 1 3
      CryptoSwift/ChaCha20.swift
  3. 1 1
      CryptoSwift/Generics.swift

+ 2 - 4
CryptoSwift/AES.swift

@@ -128,10 +128,8 @@ final public class AES {
     convenience public init?(key:String, iv:String, blockMode:CipherBlockMode = .CBC) {
         if let kkey = key.dataUsingEncoding(NSUTF8StringEncoding, allowLossyConversion: false)?.arrayOfBytes(), let iiv = iv.dataUsingEncoding(NSUTF8StringEncoding, allowLossyConversion: false)?.arrayOfBytes() {
             self.init(key: kkey, iv: iiv, blockMode: blockMode)
-        } else {
-            self.init(key: [UInt8](), iv: [UInt8](), blockMode: blockMode) //FIXME: this is due Swift bug, remove this line later, when fixed
-            return nil
         }
+        return nil
     }
     
     /**
@@ -223,7 +221,7 @@ final public class AES {
         
         state = addRoundKey(state,expandedKey, variant.Nr)
         
-        for roundCount in Array((1..<variant.Nr).reverse()) { //FIXME: WAT?
+        for roundCount in (1..<variant.Nr).reverse() {
             state = invShiftRows(state)
             state = invSubBytes(state)
             state = addRoundKey(state, expandedKey, roundCount)

+ 1 - 3
CryptoSwift/ChaCha20.swift

@@ -35,10 +35,8 @@ final public class ChaCha20 {
     convenience public init?(key:String, iv:String) {
         if let kkey = key.dataUsingEncoding(NSUTF8StringEncoding, allowLossyConversion: false)?.arrayOfBytes(), let iiv = iv.dataUsingEncoding(NSUTF8StringEncoding, allowLossyConversion: false)?.arrayOfBytes() {
             self.init(key: kkey, iv: iiv)
-        } else {
-            self.init(key: [UInt8](), iv: [UInt8]()) //FIXME: this is due Swift bug, remove this line later, when fixed
-            return nil
         }
+        return nil
     }
 
     

+ 1 - 1
CryptoSwift/Generics.swift

@@ -37,7 +37,7 @@ func integerFromBitsArray<T: UnsignedIntegerType>(bits: [Bit]) -> T
 /// Initialize integer from array of bytes.
 /// This method may be slow
 func integerWithBytes<T: IntegerType where T:ByteConvertible, T: BitshiftOperationsType>(bytes: [UInt8]) -> T {
-    var bytes = Array(bytes.reverse()) //FIXME: Array?
+    var bytes = bytes.reverse() as Array<UInt8> //FIXME: check it this is equivalent of Array(...)
     if bytes.count < sizeof(T) {
         let paddingCount = sizeof(T) - bytes.count
         if (paddingCount > 0) {