RequestInterceptorTests.swift 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601
  1. //
  2. // RequestInterceptorTests.swift
  3. //
  4. // Copyright (c) 2019 Alamofire Software Foundation (http://alamofire.org/)
  5. //
  6. // Permission is hereby granted, free of charge, to any person obtaining a copy
  7. // of this software and associated documentation files (the "Software"), to deal
  8. // in the Software without restriction, including without limitation the rights
  9. // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  10. // copies of the Software, and to permit persons to whom the Software is
  11. // furnished to do so, subject to the following conditions:
  12. //
  13. // The above copyright notice and this permission notice shall be included in
  14. // all copies or substantial portions of the Software.
  15. //
  16. // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17. // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18. // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  19. // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20. // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  21. // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  22. // THE SOFTWARE.
  23. //
  24. @testable import Alamofire
  25. import Foundation
  26. import XCTest
  27. private struct MockError: Error {}
  28. private struct RetryError: Error {}
  29. // MARK: -
  30. final class RetryResultTestCase: BaseTestCase {
  31. func testRetryRequiredProperty() {
  32. // Given, When
  33. let retry = RetryResult.retry
  34. let retryWithDelay = RetryResult.retryWithDelay(1.0)
  35. let doNotRetry = RetryResult.doNotRetry
  36. let doNotRetryWithError = RetryResult.doNotRetryWithError(MockError())
  37. // Then
  38. XCTAssertTrue(retry.retryRequired)
  39. XCTAssertTrue(retryWithDelay.retryRequired)
  40. XCTAssertFalse(doNotRetry.retryRequired)
  41. XCTAssertFalse(doNotRetryWithError.retryRequired)
  42. }
  43. func testDelayProperty() {
  44. // Given, When
  45. let retry = RetryResult.retry
  46. let retryWithDelay = RetryResult.retryWithDelay(1.0)
  47. let doNotRetry = RetryResult.doNotRetry
  48. let doNotRetryWithError = RetryResult.doNotRetryWithError(MockError())
  49. // Then
  50. XCTAssertEqual(retry.delay, nil)
  51. XCTAssertEqual(retryWithDelay.delay, 1.0)
  52. XCTAssertEqual(doNotRetry.delay, nil)
  53. XCTAssertEqual(doNotRetryWithError.delay, nil)
  54. }
  55. func testErrorProperty() {
  56. // Given, When
  57. let retry = RetryResult.retry
  58. let retryWithDelay = RetryResult.retryWithDelay(1.0)
  59. let doNotRetry = RetryResult.doNotRetry
  60. let doNotRetryWithError = RetryResult.doNotRetryWithError(MockError())
  61. // Then
  62. XCTAssertNil(retry.error)
  63. XCTAssertNil(retryWithDelay.error)
  64. XCTAssertNil(doNotRetry.error)
  65. XCTAssertTrue(doNotRetryWithError.error is MockError)
  66. }
  67. }
  68. // MARK: -
  69. final class AdapterTestCase: BaseTestCase {
  70. func testThatAdapterCallsAdaptHandler() {
  71. // Given
  72. let urlRequest = Endpoint().urlRequest
  73. let session = Session()
  74. var adapted = false
  75. let adapter = Adapter { request, _, completion in
  76. adapted = true
  77. completion(.success(request))
  78. }
  79. var result: Result<URLRequest, Error>!
  80. // When
  81. adapter.adapt(urlRequest, for: session) { result = $0 }
  82. // Then
  83. XCTAssertTrue(adapted)
  84. XCTAssertTrue(result.isSuccess)
  85. }
  86. func testThatAdapterCallsRequestRetrierDefaultImplementationInProtocolExtension() {
  87. // Given
  88. let session = Session(startRequestsImmediately: false)
  89. let request = session.request(.default)
  90. let adapter = Adapter { request, _, completion in
  91. completion(.success(request))
  92. }
  93. var result: RetryResult!
  94. // When
  95. adapter.retry(request, for: session, dueTo: MockError()) { result = $0 }
  96. // Then
  97. XCTAssertEqual(result, .doNotRetry)
  98. }
  99. func testThatAdapterCanBeImplementedAsynchronously() {
  100. // Given
  101. let urlRequest = Endpoint().urlRequest
  102. let session = Session()
  103. var adapted = false
  104. let adapter = Adapter { request, _, completion in
  105. adapted = true
  106. DispatchQueue.main.async {
  107. completion(.success(request))
  108. }
  109. }
  110. var result: Result<URLRequest, Error>!
  111. let completesExpectation = expectation(description: "adapter completes")
  112. // When
  113. adapter.adapt(urlRequest, for: session) {
  114. result = $0
  115. completesExpectation.fulfill()
  116. }
  117. waitForExpectations(timeout: timeout)
  118. // Then
  119. XCTAssertTrue(adapted)
  120. XCTAssertTrue(result.isSuccess)
  121. }
  122. }
  123. // MARK: -
  124. final class RetrierTestCase: BaseTestCase {
  125. func testThatRetrierCallsRetryHandler() {
  126. // Given
  127. let session = Session(startRequestsImmediately: false)
  128. let request = session.request(.default)
  129. var retried = false
  130. let retrier = Retrier { _, _, _, completion in
  131. retried = true
  132. completion(.retry)
  133. }
  134. var result: RetryResult!
  135. // When
  136. retrier.retry(request, for: session, dueTo: MockError()) { result = $0 }
  137. // Then
  138. XCTAssertTrue(retried)
  139. XCTAssertEqual(result, .retry)
  140. }
  141. func testThatRetrierCallsRequestAdapterDefaultImplementationInProtocolExtension() {
  142. // Given
  143. let urlRequest = Endpoint().urlRequest
  144. let session = Session()
  145. let retrier = Retrier { _, _, _, completion in
  146. completion(.retry)
  147. }
  148. var result: Result<URLRequest, Error>!
  149. // When
  150. retrier.adapt(urlRequest, for: session) { result = $0 }
  151. // Then
  152. XCTAssertTrue(result.isSuccess)
  153. }
  154. func testThatRetrierCanBeImplementedAsynchronously() {
  155. // Given
  156. let session = Session(startRequestsImmediately: false)
  157. let request = session.request(.default)
  158. var retried = false
  159. let retrier = Retrier { _, _, _, completion in
  160. retried = true
  161. DispatchQueue.main.async {
  162. completion(.retry)
  163. }
  164. }
  165. var result: RetryResult!
  166. let completesExpectation = expectation(description: "retrier completes")
  167. // When
  168. retrier.retry(request, for: session, dueTo: MockError()) {
  169. result = $0
  170. completesExpectation.fulfill()
  171. }
  172. waitForExpectations(timeout: timeout)
  173. // Then
  174. XCTAssertTrue(retried)
  175. XCTAssertEqual(result, .retry)
  176. }
  177. }
  178. // MARK: -
  179. final class InterceptorTests: BaseTestCase {
  180. func testAdaptHandlerAndRetryHandlerDefaultInitializer() {
  181. // Given
  182. let adaptHandler: AdaptHandler = { urlRequest, _, completion in completion(.success(urlRequest)) }
  183. let retryHandler: RetryHandler = { _, _, _, completion in completion(.doNotRetry) }
  184. // When
  185. let interceptor = Interceptor(adaptHandler: adaptHandler, retryHandler: retryHandler)
  186. // Then
  187. XCTAssertEqual(interceptor.adapters.count, 1)
  188. XCTAssertEqual(interceptor.retriers.count, 1)
  189. }
  190. func testAdapterAndRetrierDefaultInitializer() {
  191. // Given
  192. let adapter = Adapter { urlRequest, _, completion in completion(.success(urlRequest)) }
  193. let retrier = Retrier { _, _, _, completion in completion(.doNotRetry) }
  194. // When
  195. let interceptor = Interceptor(adapter: adapter, retrier: retrier)
  196. // Then
  197. XCTAssertEqual(interceptor.adapters.count, 1)
  198. XCTAssertEqual(interceptor.retriers.count, 1)
  199. }
  200. func testAdaptersAndRetriersDefaultInitializer() {
  201. // Given
  202. let adapter = Adapter { urlRequest, _, completion in completion(.success(urlRequest)) }
  203. let retrier = Retrier { _, _, _, completion in completion(.doNotRetry) }
  204. // When
  205. let interceptor = Interceptor(adapters: [adapter, adapter], retriers: [retrier, retrier])
  206. // Then
  207. XCTAssertEqual(interceptor.adapters.count, 2)
  208. XCTAssertEqual(interceptor.retriers.count, 2)
  209. }
  210. func testThatInterceptorCanBeComposedOfMultipleRequestInterceptors() {
  211. // Given
  212. let adapter = Adapter { request, _, completion in completion(.success(request)) }
  213. let retrier = Retrier { _, _, _, completion in completion(.doNotRetry) }
  214. let inner = Interceptor(adapter: adapter, retrier: retrier)
  215. // When
  216. let interceptor = Interceptor(interceptors: [inner])
  217. // Then
  218. XCTAssertEqual(interceptor.adapters.count, 1)
  219. XCTAssertEqual(interceptor.retriers.count, 1)
  220. }
  221. func testThatInterceptorCanAdaptRequestWithNoAdapters() {
  222. // Given
  223. let urlRequest = Endpoint().urlRequest
  224. let session = Session()
  225. let interceptor = Interceptor()
  226. var result: Result<URLRequest, Error>!
  227. // When
  228. interceptor.adapt(urlRequest, for: session) { result = $0 }
  229. // Then
  230. XCTAssertTrue(result.isSuccess)
  231. XCTAssertEqual(result.success, urlRequest)
  232. }
  233. func testThatInterceptorCanAdaptRequestWithOneAdapter() {
  234. // Given
  235. let urlRequest = Endpoint().urlRequest
  236. let session = Session()
  237. let adapter = Adapter { _, _, completion in completion(.failure(MockError())) }
  238. let interceptor = Interceptor(adapters: [adapter])
  239. var result: Result<URLRequest, Error>!
  240. // When
  241. interceptor.adapt(urlRequest, for: session) { result = $0 }
  242. // Then
  243. XCTAssertTrue(result.isFailure)
  244. XCTAssertTrue(result.failure is MockError)
  245. }
  246. func testThatInterceptorCanAdaptRequestWithMultipleAdapters() {
  247. // Given
  248. let urlRequest = Endpoint().urlRequest
  249. let session = Session()
  250. let adapter1 = Adapter { urlRequest, _, completion in completion(.success(urlRequest)) }
  251. let adapter2 = Adapter { _, _, completion in completion(.failure(MockError())) }
  252. let interceptor = Interceptor(adapters: [adapter1, adapter2])
  253. var result: Result<URLRequest, Error>!
  254. // When
  255. interceptor.adapt(urlRequest, for: session) { result = $0 }
  256. // Then
  257. XCTAssertTrue(result.isFailure)
  258. XCTAssertTrue(result.failure is MockError)
  259. }
  260. func testThatInterceptorCanAdaptRequestAsynchronously() {
  261. // Given
  262. let urlRequest = Endpoint().urlRequest
  263. let session = Session()
  264. let adapter = Adapter { _, _, completion in
  265. DispatchQueue.main.async {
  266. completion(.failure(MockError()))
  267. }
  268. }
  269. let interceptor = Interceptor(adapters: [adapter])
  270. var result: Result<URLRequest, Error>!
  271. let completesExpectation = expectation(description: "interceptor completes")
  272. // When
  273. interceptor.adapt(urlRequest, for: session) {
  274. result = $0
  275. completesExpectation.fulfill()
  276. }
  277. waitForExpectations(timeout: timeout)
  278. // Then
  279. XCTAssertTrue(result.isFailure)
  280. XCTAssertTrue(result.failure is MockError)
  281. }
  282. func testThatInterceptorCanRetryRequestWithNoRetriers() {
  283. // Given
  284. let session = Session(startRequestsImmediately: false)
  285. let request = session.request(.default)
  286. let interceptor = Interceptor()
  287. var result: RetryResult!
  288. // When
  289. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  290. // Then
  291. XCTAssertEqual(result, .doNotRetry)
  292. }
  293. func testThatInterceptorCanRetryRequestWithOneRetrier() {
  294. // Given
  295. let session = Session(startRequestsImmediately: false)
  296. let request = session.request(.default)
  297. let retrier = Retrier { _, _, _, completion in completion(.retry) }
  298. let interceptor = Interceptor(retriers: [retrier])
  299. var result: RetryResult!
  300. // When
  301. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  302. // Then
  303. XCTAssertEqual(result, .retry)
  304. }
  305. func testThatInterceptorCanRetryRequestWithMultipleRetriers() {
  306. // Given
  307. let session = Session(startRequestsImmediately: false)
  308. let request = session.request(.default)
  309. let retrier1 = Retrier { _, _, _, completion in completion(.doNotRetry) }
  310. let retrier2 = Retrier { _, _, _, completion in completion(.retry) }
  311. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  312. var result: RetryResult!
  313. // When
  314. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  315. // Then
  316. XCTAssertEqual(result, .retry)
  317. }
  318. func testThatInterceptorCanRetryRequestAsynchronously() {
  319. // Given
  320. let session = Session(startRequestsImmediately: false)
  321. let request = session.request(.default)
  322. let retrier = Retrier { _, _, _, completion in
  323. DispatchQueue.main.async {
  324. completion(.retry)
  325. }
  326. }
  327. let interceptor = Interceptor(retriers: [retrier])
  328. var result: RetryResult!
  329. let completesExpectation = expectation(description: "interceptor completes")
  330. // When
  331. interceptor.retry(request, for: session, dueTo: MockError()) {
  332. result = $0
  333. completesExpectation.fulfill()
  334. }
  335. waitForExpectations(timeout: timeout)
  336. // Then
  337. XCTAssertEqual(result, .retry)
  338. }
  339. func testThatInterceptorStopsIteratingThroughPendingRetriersWithRetryResult() {
  340. // Given
  341. let session = Session(startRequestsImmediately: false)
  342. let request = session.request(.default)
  343. var retrier2Called = false
  344. let retrier1 = Retrier { _, _, _, completion in completion(.retry) }
  345. let retrier2 = Retrier { _, _, _, completion in retrier2Called = true; completion(.doNotRetry) }
  346. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  347. var result: RetryResult!
  348. // When
  349. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  350. // Then
  351. XCTAssertEqual(result, .retry)
  352. XCTAssertFalse(retrier2Called)
  353. }
  354. func testThatInterceptorStopsIteratingThroughPendingRetriersWithRetryWithDelayResult() {
  355. // Given
  356. let session = Session(startRequestsImmediately: false)
  357. let request = session.request(.default)
  358. var retrier2Called = false
  359. let retrier1 = Retrier { _, _, _, completion in completion(.retryWithDelay(1.0)) }
  360. let retrier2 = Retrier { _, _, _, completion in retrier2Called = true; completion(.doNotRetry) }
  361. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  362. var result: RetryResult!
  363. // When
  364. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  365. // Then
  366. XCTAssertEqual(result, .retryWithDelay(1.0))
  367. XCTAssertEqual(result.delay, 1.0)
  368. XCTAssertFalse(retrier2Called)
  369. }
  370. func testThatInterceptorStopsIteratingThroughPendingRetriersWithDoNotRetryResult() {
  371. // Given
  372. let session = Session(startRequestsImmediately: false)
  373. let request = session.request(.default)
  374. var retrier2Called = false
  375. let retrier1 = Retrier { _, _, _, completion in completion(.doNotRetryWithError(RetryError())) }
  376. let retrier2 = Retrier { _, _, _, completion in retrier2Called = true; completion(.doNotRetry) }
  377. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  378. var result: RetryResult!
  379. // When
  380. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  381. // Then
  382. XCTAssertEqual(result, RetryResult.doNotRetryWithError(RetryError()))
  383. XCTAssertTrue(result.error is RetryError)
  384. XCTAssertFalse(retrier2Called)
  385. }
  386. }
  387. // MARK: - Functional Tests
  388. final class InterceptorRequestTests: BaseTestCase {
  389. func testThatRetryPolicyRetriesRequestTimeout() {
  390. // Given
  391. let interceptor = InspectorInterceptor(RetryPolicy(retryLimit: 1, exponentialBackoffScale: 0.1))
  392. let urlRequest = Endpoint.delay(1).modifying(\.timeout, to: 0.01)
  393. let expect = expectation(description: "request completed")
  394. // When
  395. let request = AF.request(urlRequest, interceptor: interceptor).response { _ in
  396. expect.fulfill()
  397. }
  398. waitForExpectations(timeout: timeout)
  399. // Then
  400. XCTAssertEqual(request.tasks.count, 2, "There should be two tasks, one original, one retry.")
  401. XCTAssertEqual(interceptor.retryCalledCount, 2, "retry() should be called twice.")
  402. XCTAssertEqual(interceptor.retries, [.retryWithDelay(0.1), .doNotRetry], "RetryResults should retryWithDelay, doNotRetry")
  403. }
  404. }
  405. // MARK: - Helpers
  406. /// Class which captures the output of any underlying `RequestInterceptor`.
  407. final class InspectorInterceptor<Interceptor: RequestInterceptor>: RequestInterceptor {
  408. var onAdaptation: ((Result<URLRequest, Error>) -> Void)?
  409. var onRetry: ((RetryResult) -> Void)?
  410. private(set) var adaptations: [Result<URLRequest, Error>] = []
  411. private(set) var retries: [RetryResult] = []
  412. /// Number of times `retry` was called.
  413. var retryCalledCount: Int { retries.count }
  414. let interceptor: Interceptor
  415. init(_ interceptor: Interceptor) {
  416. self.interceptor = interceptor
  417. }
  418. func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
  419. interceptor.adapt(urlRequest, for: session) { result in
  420. self.adaptations.append(result)
  421. completion(result)
  422. self.onAdaptation?(result)
  423. }
  424. }
  425. func retry(_ request: Request, for session: Session, dueTo error: Error, completion: @escaping (RetryResult) -> Void) {
  426. interceptor.retry(request, for: session, dueTo: error) { result in
  427. self.retries.append(result)
  428. completion(result)
  429. self.onRetry?(result)
  430. }
  431. }
  432. }
  433. /// Retry a request once, allowing the second to succeed using the method path.
  434. final class SingleRetrier: RequestInterceptor {
  435. private var hasRetried = false
  436. func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
  437. if hasRetried {
  438. let method = urlRequest.method ?? .get
  439. let endpoint = Endpoint(path: .method(method),
  440. method: method,
  441. headers: urlRequest.headers)
  442. completion(.success(endpoint.urlRequest))
  443. } else {
  444. completion(.success(urlRequest))
  445. }
  446. }
  447. func retry(_ request: Request, for session: Session, dueTo error: Error, completion: @escaping (RetryResult) -> Void) {
  448. completion(hasRetried ? .doNotRetry : .retry)
  449. hasRetried = true
  450. }
  451. }
  452. extension RetryResult: Equatable {
  453. public static func ==(lhs: RetryResult, rhs: RetryResult) -> Bool {
  454. switch (lhs, rhs) {
  455. case (.retry, .retry),
  456. (.doNotRetry, .doNotRetry),
  457. (.doNotRetryWithError, .doNotRetryWithError):
  458. return true
  459. case let (.retryWithDelay(leftDelay), .retryWithDelay(rightDelay)):
  460. return leftDelay == rightDelay
  461. default:
  462. return false
  463. }
  464. }
  465. }