RequestInterceptorTests.swift 20 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610
  1. //
  2. // RequestInterceptorTests.swift
  3. //
  4. // Copyright (c) 2019 Alamofire Software Foundation (http://alamofire.org/)
  5. //
  6. // Permission is hereby granted, free of charge, to any person obtaining a copy
  7. // of this software and associated documentation files (the "Software"), to deal
  8. // in the Software without restriction, including without limitation the rights
  9. // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
  10. // copies of the Software, and to permit persons to whom the Software is
  11. // furnished to do so, subject to the following conditions:
  12. //
  13. // The above copyright notice and this permission notice shall be included in
  14. // all copies or substantial portions of the Software.
  15. //
  16. // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17. // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18. // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
  19. // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20. // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
  21. // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
  22. // THE SOFTWARE.
  23. //
  24. @testable import Alamofire
  25. import Foundation
  26. import XCTest
  27. private struct MockError: Error {}
  28. private struct RetryError: Error {}
  29. // MARK: -
  30. final class RetryResultTestCase: BaseTestCase {
  31. func testRetryRequiredProperty() {
  32. // Given, When
  33. let retry = RetryResult.retry
  34. let retryWithDelay = RetryResult.retryWithDelay(1.0)
  35. let doNotRetry = RetryResult.doNotRetry
  36. let doNotRetryWithError = RetryResult.doNotRetryWithError(MockError())
  37. // Then
  38. XCTAssertTrue(retry.retryRequired)
  39. XCTAssertTrue(retryWithDelay.retryRequired)
  40. XCTAssertFalse(doNotRetry.retryRequired)
  41. XCTAssertFalse(doNotRetryWithError.retryRequired)
  42. }
  43. func testDelayProperty() {
  44. // Given, When
  45. let retry = RetryResult.retry
  46. let retryWithDelay = RetryResult.retryWithDelay(1.0)
  47. let doNotRetry = RetryResult.doNotRetry
  48. let doNotRetryWithError = RetryResult.doNotRetryWithError(MockError())
  49. // Then
  50. XCTAssertEqual(retry.delay, nil)
  51. XCTAssertEqual(retryWithDelay.delay, 1.0)
  52. XCTAssertEqual(doNotRetry.delay, nil)
  53. XCTAssertEqual(doNotRetryWithError.delay, nil)
  54. }
  55. func testErrorProperty() {
  56. // Given, When
  57. let retry = RetryResult.retry
  58. let retryWithDelay = RetryResult.retryWithDelay(1.0)
  59. let doNotRetry = RetryResult.doNotRetry
  60. let doNotRetryWithError = RetryResult.doNotRetryWithError(MockError())
  61. // Then
  62. XCTAssertNil(retry.error)
  63. XCTAssertNil(retryWithDelay.error)
  64. XCTAssertNil(doNotRetry.error)
  65. XCTAssertTrue(doNotRetryWithError.error is MockError)
  66. }
  67. }
  68. // MARK: -
  69. final class AdapterTestCase: BaseTestCase {
  70. func testThatAdapterCallsAdaptHandler() {
  71. // Given
  72. let urlRequest = URLRequest.makeHTTPBinRequest()
  73. let session = Session()
  74. var adapted = false
  75. let adapter = Adapter { request, _, completion in
  76. adapted = true
  77. completion(.success(request))
  78. }
  79. var result: Result<URLRequest, Error>!
  80. // When
  81. adapter.adapt(urlRequest, for: session) { result = $0 }
  82. // Then
  83. XCTAssertTrue(adapted)
  84. XCTAssertTrue(result.isSuccess)
  85. }
  86. func testThatAdapterCallsRequestRetrierDefaultImplementationInProtocolExtension() {
  87. // Given
  88. let url = URL.makeHTTPBinURL()
  89. let session = Session(startRequestsImmediately: false)
  90. let request = session.request(url)
  91. let adapter = Adapter { request, _, completion in
  92. completion(.success(request))
  93. }
  94. var result: RetryResult!
  95. // When
  96. adapter.retry(request, for: session, dueTo: MockError()) { result = $0 }
  97. // Then
  98. XCTAssertEqual(result, .doNotRetry)
  99. }
  100. func testThatAdapterCanBeImplementedAsynchronously() {
  101. // Given
  102. let urlRequest = URLRequest.makeHTTPBinRequest()
  103. let session = Session()
  104. var adapted = false
  105. let adapter = Adapter { request, _, completion in
  106. adapted = true
  107. DispatchQueue.main.async {
  108. completion(.success(request))
  109. }
  110. }
  111. var result: Result<URLRequest, Error>!
  112. let completesExpectation = expectation(description: "adapter completes")
  113. // When
  114. adapter.adapt(urlRequest, for: session) {
  115. result = $0
  116. completesExpectation.fulfill()
  117. }
  118. waitForExpectations(timeout: timeout)
  119. // Then
  120. XCTAssertTrue(adapted)
  121. XCTAssertTrue(result.isSuccess)
  122. }
  123. }
  124. // MARK: -
  125. final class RetrierTestCase: BaseTestCase {
  126. func testThatRetrierCallsRetryHandler() {
  127. // Given
  128. let url = URL.makeHTTPBinURL()
  129. let session = Session(startRequestsImmediately: false)
  130. let request = session.request(url)
  131. var retried = false
  132. let retrier = Retrier { _, _, _, completion in
  133. retried = true
  134. completion(.retry)
  135. }
  136. var result: RetryResult!
  137. // When
  138. retrier.retry(request, for: session, dueTo: MockError()) { result = $0 }
  139. // Then
  140. XCTAssertTrue(retried)
  141. XCTAssertEqual(result, .retry)
  142. }
  143. func testThatRetrierCallsRequestAdapterDefaultImplementationInProtocolExtension() {
  144. // Given
  145. let urlRequest = URLRequest.makeHTTPBinRequest()
  146. let session = Session()
  147. let retrier = Retrier { _, _, _, completion in
  148. completion(.retry)
  149. }
  150. var result: Result<URLRequest, Error>!
  151. // When
  152. retrier.adapt(urlRequest, for: session) { result = $0 }
  153. // Then
  154. XCTAssertTrue(result.isSuccess)
  155. }
  156. func testThatRetrierCanBeImplementedAsynchronously() {
  157. // Given
  158. let url = URL.makeHTTPBinURL()
  159. let session = Session(startRequestsImmediately: false)
  160. let request = session.request(url)
  161. var retried = false
  162. let retrier = Retrier { _, _, _, completion in
  163. retried = true
  164. DispatchQueue.main.async {
  165. completion(.retry)
  166. }
  167. }
  168. var result: RetryResult!
  169. let completesExpectation = expectation(description: "retrier completes")
  170. // When
  171. retrier.retry(request, for: session, dueTo: MockError()) {
  172. result = $0
  173. completesExpectation.fulfill()
  174. }
  175. waitForExpectations(timeout: timeout)
  176. // Then
  177. XCTAssertTrue(retried)
  178. XCTAssertEqual(result, .retry)
  179. }
  180. }
  181. // MARK: -
  182. final class InterceptorTests: BaseTestCase {
  183. func testAdaptHandlerAndRetryHandlerDefaultInitializer() {
  184. // Given
  185. let adaptHandler: AdaptHandler = { urlRequest, _, completion in completion(.success(urlRequest)) }
  186. let retryHandler: RetryHandler = { _, _, _, completion in completion(.doNotRetry) }
  187. // When
  188. let interceptor = Interceptor(adaptHandler: adaptHandler, retryHandler: retryHandler)
  189. // Then
  190. XCTAssertEqual(interceptor.adapters.count, 1)
  191. XCTAssertEqual(interceptor.retriers.count, 1)
  192. }
  193. func testAdapterAndRetrierDefaultInitializer() {
  194. // Given
  195. let adapter = Adapter { urlRequest, _, completion in completion(.success(urlRequest)) }
  196. let retrier = Retrier { _, _, _, completion in completion(.doNotRetry) }
  197. // When
  198. let interceptor = Interceptor(adapter: adapter, retrier: retrier)
  199. // Then
  200. XCTAssertEqual(interceptor.adapters.count, 1)
  201. XCTAssertEqual(interceptor.retriers.count, 1)
  202. }
  203. func testAdaptersAndRetriersDefaultInitializer() {
  204. // Given
  205. let adapter = Adapter { urlRequest, _, completion in completion(.success(urlRequest)) }
  206. let retrier = Retrier { _, _, _, completion in completion(.doNotRetry) }
  207. // When
  208. let interceptor = Interceptor(adapters: [adapter, adapter], retriers: [retrier, retrier])
  209. // Then
  210. XCTAssertEqual(interceptor.adapters.count, 2)
  211. XCTAssertEqual(interceptor.retriers.count, 2)
  212. }
  213. func testThatInterceptorCanBeComposedOfMultipleRequestInterceptors() {
  214. // Given
  215. let adapter = Adapter { request, _, completion in completion(.success(request)) }
  216. let retrier = Retrier { _, _, _, completion in completion(.doNotRetry) }
  217. let inner = Interceptor(adapter: adapter, retrier: retrier)
  218. // When
  219. let interceptor = Interceptor(interceptors: [inner])
  220. // Then
  221. XCTAssertEqual(interceptor.adapters.count, 1)
  222. XCTAssertEqual(interceptor.retriers.count, 1)
  223. }
  224. func testThatInterceptorCanAdaptRequestWithNoAdapters() {
  225. // Given
  226. let urlRequest = URLRequest.makeHTTPBinRequest()
  227. let session = Session()
  228. let interceptor = Interceptor()
  229. var result: Result<URLRequest, Error>!
  230. // When
  231. interceptor.adapt(urlRequest, for: session) { result = $0 }
  232. // Then
  233. XCTAssertTrue(result.isSuccess)
  234. XCTAssertEqual(result.success, urlRequest)
  235. }
  236. func testThatInterceptorCanAdaptRequestWithOneAdapter() {
  237. // Given
  238. let urlRequest = URLRequest.makeHTTPBinRequest()
  239. let session = Session()
  240. let adapter = Adapter { _, _, completion in completion(.failure(MockError())) }
  241. let interceptor = Interceptor(adapters: [adapter])
  242. var result: Result<URLRequest, Error>!
  243. // When
  244. interceptor.adapt(urlRequest, for: session) { result = $0 }
  245. // Then
  246. XCTAssertTrue(result.isFailure)
  247. XCTAssertTrue(result.failure is MockError)
  248. }
  249. func testThatInterceptorCanAdaptRequestWithMultipleAdapters() {
  250. // Given
  251. let urlRequest = URLRequest.makeHTTPBinRequest()
  252. let session = Session()
  253. let adapter1 = Adapter { urlRequest, _, completion in completion(.success(urlRequest)) }
  254. let adapter2 = Adapter { _, _, completion in completion(.failure(MockError())) }
  255. let interceptor = Interceptor(adapters: [adapter1, adapter2])
  256. var result: Result<URLRequest, Error>!
  257. // When
  258. interceptor.adapt(urlRequest, for: session) { result = $0 }
  259. // Then
  260. XCTAssertTrue(result.isFailure)
  261. XCTAssertTrue(result.failure is MockError)
  262. }
  263. func testThatInterceptorCanAdaptRequestAsynchronously() {
  264. // Given
  265. let urlRequest = URLRequest.makeHTTPBinRequest()
  266. let session = Session()
  267. let adapter = Adapter { _, _, completion in
  268. DispatchQueue.main.async {
  269. completion(.failure(MockError()))
  270. }
  271. }
  272. let interceptor = Interceptor(adapters: [adapter])
  273. var result: Result<URLRequest, Error>!
  274. let completesExpectation = expectation(description: "interceptor completes")
  275. // When
  276. interceptor.adapt(urlRequest, for: session) {
  277. result = $0
  278. completesExpectation.fulfill()
  279. }
  280. waitForExpectations(timeout: timeout)
  281. // Then
  282. XCTAssertTrue(result.isFailure)
  283. XCTAssertTrue(result.failure is MockError)
  284. }
  285. func testThatInterceptorCanRetryRequestWithNoRetriers() {
  286. // Given
  287. let url = URL.makeHTTPBinURL()
  288. let session = Session(startRequestsImmediately: false)
  289. let request = session.request(url)
  290. let interceptor = Interceptor()
  291. var result: RetryResult!
  292. // When
  293. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  294. // Then
  295. XCTAssertEqual(result, .doNotRetry)
  296. }
  297. func testThatInterceptorCanRetryRequestWithOneRetrier() {
  298. // Given
  299. let url = URL.makeHTTPBinURL()
  300. let session = Session(startRequestsImmediately: false)
  301. let request = session.request(url)
  302. let retrier = Retrier { _, _, _, completion in completion(.retry) }
  303. let interceptor = Interceptor(retriers: [retrier])
  304. var result: RetryResult!
  305. // When
  306. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  307. // Then
  308. XCTAssertEqual(result, .retry)
  309. }
  310. func testThatInterceptorCanRetryRequestWithMultipleRetriers() {
  311. // Given
  312. let url = URL.makeHTTPBinURL()
  313. let session = Session(startRequestsImmediately: false)
  314. let request = session.request(url)
  315. let retrier1 = Retrier { _, _, _, completion in completion(.doNotRetry) }
  316. let retrier2 = Retrier { _, _, _, completion in completion(.retry) }
  317. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  318. var result: RetryResult!
  319. // When
  320. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  321. // Then
  322. XCTAssertEqual(result, .retry)
  323. }
  324. func testThatInterceptorCanRetryRequestAsynchronously() {
  325. // Given
  326. let url = URL.makeHTTPBinURL()
  327. let session = Session(startRequestsImmediately: false)
  328. let request = session.request(url)
  329. let retrier = Retrier { _, _, _, completion in
  330. DispatchQueue.main.async {
  331. completion(.retry)
  332. }
  333. }
  334. let interceptor = Interceptor(retriers: [retrier])
  335. var result: RetryResult!
  336. let completesExpectation = expectation(description: "interceptor completes")
  337. // When
  338. interceptor.retry(request, for: session, dueTo: MockError()) {
  339. result = $0
  340. completesExpectation.fulfill()
  341. }
  342. waitForExpectations(timeout: timeout)
  343. // Then
  344. XCTAssertEqual(result, .retry)
  345. }
  346. func testThatInterceptorStopsIteratingThroughPendingRetriersWithRetryResult() {
  347. // Given
  348. let url = URL.makeHTTPBinURL()
  349. let session = Session(startRequestsImmediately: false)
  350. let request = session.request(url)
  351. var retrier2Called = false
  352. let retrier1 = Retrier { _, _, _, completion in completion(.retry) }
  353. let retrier2 = Retrier { _, _, _, completion in retrier2Called = true; completion(.doNotRetry) }
  354. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  355. var result: RetryResult!
  356. // When
  357. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  358. // Then
  359. XCTAssertEqual(result, .retry)
  360. XCTAssertFalse(retrier2Called)
  361. }
  362. func testThatInterceptorStopsIteratingThroughPendingRetriersWithRetryWithDelayResult() {
  363. // Given
  364. let url = URL.makeHTTPBinURL()
  365. let session = Session(startRequestsImmediately: false)
  366. let request = session.request(url)
  367. var retrier2Called = false
  368. let retrier1 = Retrier { _, _, _, completion in completion(.retryWithDelay(1.0)) }
  369. let retrier2 = Retrier { _, _, _, completion in retrier2Called = true; completion(.doNotRetry) }
  370. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  371. var result: RetryResult!
  372. // When
  373. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  374. // Then
  375. XCTAssertEqual(result, .retryWithDelay(1.0))
  376. XCTAssertEqual(result.delay, 1.0)
  377. XCTAssertFalse(retrier2Called)
  378. }
  379. func testThatInterceptorStopsIteratingThroughPendingRetriersWithDoNotRetryResult() {
  380. // Given
  381. let url = URL.makeHTTPBinURL()
  382. let session = Session(startRequestsImmediately: false)
  383. let request = session.request(url)
  384. var retrier2Called = false
  385. let retrier1 = Retrier { _, _, _, completion in completion(.doNotRetryWithError(RetryError())) }
  386. let retrier2 = Retrier { _, _, _, completion in retrier2Called = true; completion(.doNotRetry) }
  387. let interceptor = Interceptor(retriers: [retrier1, retrier2])
  388. var result: RetryResult!
  389. // When
  390. interceptor.retry(request, for: session, dueTo: MockError()) { result = $0 }
  391. // Then
  392. XCTAssertEqual(result, RetryResult.doNotRetryWithError(RetryError()))
  393. XCTAssertTrue(result.error is RetryError)
  394. XCTAssertFalse(retrier2Called)
  395. }
  396. }
  397. // MARK: - Functional Tests
  398. final class InterceptorRequestTests: BaseTestCase {
  399. func testThatRetryPolicyRetriesRequestTimeout() {
  400. // Given
  401. let interceptor = InspectorInterceptor(RetryPolicy(retryLimit: 1, exponentialBackoffScale: 0.1))
  402. let urlRequest = URLRequest.makeHTTPBinRequest(path: "delay/1", timeout: 0.01)
  403. let expect = expectation(description: "request completed")
  404. // When
  405. let request = AF.request(urlRequest, interceptor: interceptor).response { _ in
  406. expect.fulfill()
  407. }
  408. waitForExpectations(timeout: timeout)
  409. // Then
  410. XCTAssertEqual(request.tasks.count, 2, "There should be two tasks, one original, one retry.")
  411. XCTAssertEqual(interceptor.retryCalledCount, 2, "retry() should be called twice.")
  412. XCTAssertEqual(interceptor.retries, [.retryWithDelay(0.1), .doNotRetry], "RetryResults should retryWithDelay, doNotRetry")
  413. }
  414. }
  415. // MARK: - Helpers
  416. /// Class which captures the output of any underlying `RequestInterceptor`.
  417. final class InspectorInterceptor<Interceptor: RequestInterceptor>: RequestInterceptor {
  418. var onAdaptation: ((Result<URLRequest, Error>) -> Void)?
  419. var onRetry: ((RetryResult) -> Void)?
  420. private(set) var adaptations: [Result<URLRequest, Error>] = []
  421. private(set) var retries: [RetryResult] = []
  422. /// Number of times `retry` was called.
  423. var retryCalledCount: Int { retries.count }
  424. let interceptor: Interceptor
  425. init(_ interceptor: Interceptor) {
  426. self.interceptor = interceptor
  427. }
  428. func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
  429. interceptor.adapt(urlRequest, for: session) { result in
  430. self.adaptations.append(result)
  431. completion(result)
  432. self.onAdaptation?(result)
  433. }
  434. }
  435. func retry(_ request: Request, for session: Session, dueTo error: Error, completion: @escaping (RetryResult) -> Void) {
  436. interceptor.retry(request, for: session, dueTo: error) { result in
  437. self.retries.append(result)
  438. completion(result)
  439. self.onRetry?(result)
  440. }
  441. }
  442. }
  443. /// Retry a request once, allowing the second to succeed using the method path.
  444. final class SingleRetrier: RequestInterceptor {
  445. private var hasRetried = false
  446. func adapt(_ urlRequest: URLRequest, for session: Session, completion: @escaping (Result<URLRequest, Error>) -> Void) {
  447. if hasRetried {
  448. var request = URLRequest.makeHTTPBinRequest(path: "\(urlRequest.httpMethod?.lowercased() ?? "get")")
  449. request.method = urlRequest.method
  450. request.headers = urlRequest.headers
  451. completion(.success(request))
  452. } else {
  453. completion(.success(urlRequest))
  454. }
  455. }
  456. func retry(_ request: Request, for session: Session, dueTo error: Error, completion: @escaping (RetryResult) -> Void) {
  457. completion(hasRetried ? .doNotRetry : .retry)
  458. hasRetried = true
  459. }
  460. }
  461. extension RetryResult: Equatable {
  462. public static func ==(lhs: RetryResult, rhs: RetryResult) -> Bool {
  463. switch (lhs, rhs) {
  464. case (.retry, .retry),
  465. (.doNotRetry, .doNotRetry),
  466. (.doNotRetryWithError, .doNotRetryWithError):
  467. return true
  468. case let (.retryWithDelay(leftDelay), .retryWithDelay(rightDelay)):
  469. return leftDelay == rightDelay
  470. default:
  471. return false
  472. }
  473. }
  474. }